Fix working icon position when sending or deleting a comment#7280
Merged
MorrisJobke merged 2 commits intomasterfrom Nov 27, 2017
Merged
Conversation
The submit confirm icon is shown as the background image of an absolutely positioned input element, so the CSS rules for the submit working icon were modified to match those of the submit confirm icon. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When a comment was being deleted the submit working icon was shown. Now the submit working icon is kept hidden in that case and a specific delete working icon, which is shown at the same position as the delete icon, is used instead. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
nickvergessen
approved these changes
Nov 27, 2017
Member
|
Much better in place |
Member
|
CI failure is due to codecov 503. |
Member
Author
Contributor
|
I think I'll have a go with this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix working icon position when sending or deleting a comment
The working/loading icon is now placed at the same position as the confirm and delete "buttons" while a comment is being sent or deleted.
To place the working icon at the same position as the confirm button I have just copied the CSS rules used by the absolutely positioned input element of the confirm button. It looks like a terribly brittle approach, so @nextcloud/designers feel free to improve it ;-)
Also please ignore the input field not being disabled in the screenshots below; that is a different issue ;-) (#7266)
Send, before:
Send, after:
Delete, before:
Delete, after:
